Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new I/O engine in CLI commands and features #7010

Closed
wants to merge 8 commits into from
Closed

Use new I/O engine in CLI commands and features #7010

wants to merge 8 commits into from

Conversation

Al2Klimov
Copy link
Member

@Al2Klimov Al2Klimov commented Mar 12, 2019 •
edited by dnsmichi
Loading

CLI Commands

  • node wizard/setup
  • debug console
  • check_nscp_api

Features

  • InfluxDB
  • Elasticsearch

Cleanup

  • Drop ApiClient and HttpClientConnection classes

@Al2Klimov
Copy link
Member Author

Substitutes #6990. Waiting until #7005 purrs like a cat.

@Al2Klimov
Copy link
Member Author

Al2Klimov commented Mar 12, 2019 •
edited
Loading

  • ... and has been merged.

@Al2Klimov Al2Klimov self-assigned this Mar 12, 2019
@dnsmichi dnsmichi added area/distributed Distributed monitoring (master, satellites, clients) area/cli Command line helpers area/metrics General metrics handling area/api REST API TBD To be defined - We aren't certain about this yet labels Mar 12, 2019
@Al2Klimov Al2Klimov force-pushed the feature/boost-asio-features branch from 10765c9 to b89dc8b Compare April 1, 2019 15:20
@Al2Klimov Al2Klimov changed the title [WIP] Use new I/O engine in node wizard and InfluxdbWriter Use new I/O engine in node wizard and InfluxdbWriter Apr 1, 2019
@Al2Klimov Al2Klimov removed their assignment Apr 1, 2019
@Al2Klimov Al2Klimov requested a review from dnsmichi April 1, 2019 16:01
@dnsmichi dnsmichi added this to the 2.11.0 milestone Apr 1, 2019
@dnsmichi dnsmichi mentioned this pull request Apr 1, 2019
Closed
27 tasks
@dnsmichi dnsmichi self-assigned this Apr 2, 2019
@dnsmichi dnsmichi removed the TBD To be defined - We aren't certain about this yet label Apr 2, 2019
@dnsmichi dnsmichi mentioned this pull request Apr 3, 2019
Merged
@dnsmichi dnsmichi changed the title Use new I/O engine in node wizard and InfluxdbWriter Use new I/O engine in CLI commands and features Apr 5, 2019
@dnsmichi
Copy link
Contributor

dnsmichi commented Apr 5, 2019 •
edited
Loading

The first part of the debug console works, the auto complete script needs rework. The 2 callbacks with exception loops are horrible to understand and refactor into readable code.

Screen Shot 2019-04-05 at 16 03 18

@dnsmichi dnsmichi force-pushed the feature/boost-asio-features branch from b89dc8b to 62b5779 Compare April 5, 2019 14:38
@dnsmichi
Copy link
Contributor

Will be split into separate PRs.

@dnsmichi
Copy link
Contributor

Closing in favour of the split PRs.

@dnsmichi dnsmichi closed this Apr 25, 2019
@dnsmichi dnsmichi removed this from the 2.11.0 milestone Apr 25, 2019
@Al2Klimov Al2Klimov deleted the feature/boost-asio-features branch April 25, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnsmichi dnsmichi Awaiting requested review from dnsmichi

Assignees

@dnsmichi dnsmichi

Labels
area/api REST API area/cli Command line helpers area/distributed Distributed monitoring (master, satellites, clients) area/metrics General metrics handling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Al2Klimov @dnsmichi